Skip to content

test: deflake test-tls-resume-servername - #67450

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
christianaurichzm:deflake-tls-resume-servername
Nov 15, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
christianaurichzm:deflake-tls-resume-servername

Conversation

@christianaurichzm

Copy link
Copy Markdown
Member

test-tls-resume-servername fails intermittently with ERR_SSL_TLSV1_ALERT_DECRYPT_ERROR, on 6 PRs in the latest reliability report.

On resumption, OpenSSL also passes the session ticket to the server's PSK callback as an identity, cut at its first NUL byte, and Node forwards it to pskCallback when that prefix is valid UTF-8. The test's callback returned the key for any identity, so the ticket was taken for an external PSK and the handshake failed. This only answers for 'client'.

Against the 2026-11-11 nightly, which predates the SNI change, the PSK part of the test fails 24/2000 runs before this change and 0/2000 after.

Refs: nodejs/reliability#1722

The PSK server's pskCallback answered every identity, but OpenSSL also
asks it about the resumption ticket, cut at its first NUL byte. When
that prefix is valid UTF-8, about 1% of the time, the ticket was taken
for an external PSK and the handshake failed with decrypt_error. Only
answer for the identity the client sends.

Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 13, 2026
@christianaurichzm christianaurichzm added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Nov 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (7b4c9e3) to head (19e96c1).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67450      +/-   ##
==========================================
- Coverage   90.71%   90.71%   -0.01%     
==========================================
  Files         801      802       +1     
  Lines      281889   282109     +220     
  Branches    54315    54354      +39     
==========================================
+ Hits       255709   255906     +197     
- Misses      16307    16327      +20     
- Partials     9873     9876       +3     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 13, 2026

@pimterry pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@panva panva added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 13, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@christianaurichzm christianaurichzm added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 14, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@christianaurichzm christianaurichzm added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Failed to resume CI

✖ CI job 79060 is in status RUNNING, skipping resume

Full Auto Start CI output
�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 67450
�[36m⠙�[39m Looking for CI runs for pull request 67450
�[36m⠙�[39m Getting PR from nodejs/node/pull/67450
�[36m⠙�[39m Getting reviews from nodejs/node/pull/67450
�[36m⠙�[39m Getting comments from nodejs/node/pull/67450
✔  Found PR CI job 79060
�[36m⠹�[39m Querying data for job/node-test-pull-request/79060/
�[36m⠹�[39m Querying data for job/node-test-pull-request/79060/
�[36m⠹�[39m Querying API for job/node-test-pull-request/79060/
✔  Build data downloaded
   ✖  CI job 79060 is in status RUNNING, skipping resume

View workflow run

@christianaurichzm christianaurichzm removed the resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. label Nov 14, 2026
@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 14, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 80fc1ef into nodejs:main Nov 15, 2026
91 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 80fc1ef

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 15, 2026
aduh95 pushed a commit that referenced this pull request Nov 16, 2026
The PSK server's pskCallback answered every identity, but OpenSSL also
asks it about the resumption ticket, cut at its first NUL byte. When
that prefix is valid UTF-8, about 1% of the time, the ticket was taken
for an external PSK and the handshake failed with decrypt_error. Only
answer for the identity the client sends.

Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
PR-URL: #67450
Refs: nodejs/reliability#1722
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants